This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v9 1/2] Y2038: Add 64-bit time for all architectures


Hi Joseph,

On Thu, 11 Oct 2018 14:15:33 +0000, Joseph Myers
<joseph@codesourcery.com> wrote :

> On Thu, 11 Oct 2018, Albert ARIBAUD wrote:
> 
> > - We need to determine the size of the target architecture time_t type
> >   in order to decide whether we need to define a 64-bit time type.  
> 
> Yes.
> 
> > - we do not have the time_t size readily available, so we must infer it
> >   based on some other type size.  
> 
> That happens in bits/timesize.h.
> 
> Once bits/timesize.h exists, the value from there can be used in 
> bits/time64.h, so only one bits/time64.h should be needed.

Ok.

> This patch could be split in two.  The first would add bits/timesize.h 
> (two variants), and maybe also use __TIMESIZE in bits/msq-pad.h and remove 
> the x86-specific version of that header.  The second would add 
> bits/time64.h (one variant).

I assume you mean bits/msq.h, not bits/msq-pad.h.

But shouldn't modifications to bits/msq.h be put in a separate,
dedicated patch?

Cordialement,
Albert ARIBAUD
3ADEV


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]