This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Include most of elf/ modules-names in modules-names-tests

From: Florian Weimer <fweimer at redhat dot com>
To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
Cc: zackw at panix dot com
Date: Wed, 12 Sep 2018 14:38:55 +0200
Subject: Re: Include most of elf/ modules-names in modules-names-tests
References: <alpine.DEB.2.21.1809112018570.9221@digraph.polyomino.org.uk> <alpine.DEB.2.21.1809121214530.28943@digraph.polyomino.org.uk>

On 09/12/2018 02:15 PM, Joseph Myers wrote:

+modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\
+				   $(modules-names))

Perhaps add a comment that the reliance on internal headers is thereason for filtering out these module names?


Patch looks fine to me otherwise.

Thanks,
Florian

References:
- Include most of elf/ modules-names in modules-names-tests
  - From: Joseph Myers
- Re: Include most of elf/ modules-names in modules-names-tests
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]