This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: Terry Guo <terry dot xpguo at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>, "Lu, Hongjiu" <hongjiu dot lu at intel dot com>
Date: Wed, 12 Sep 2018 04:57:04 -0700
Subject: Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
References: <CAATtE7D_q4qd4Y9uTP-JmfJZ_zGT01HYYtKZW0L3_Q+v3TCegA@mail.gmail.com> <a7079dfe-ec31-f4e4-4b26-c1b12d2b77bb@redhat.com>

On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 09/07/2018 09:06 AM, Terry Guo wrote:
>>
>> +       /* Clearing frame pointer is insufficient, use CFI.  */
>> +       cfi_undefined (eip)
>
>
> Isn't this a separate fix?

Since _start now includes CFI, without "cfi_undefined (eip)",  unwinder may not
terminate at _start and one unwind test will fail.

> The ChangeLog or the commit message should mention ENDBR32 (“Use ENTRY to
> insert ENDBR32 when building for CET” or something like that).
>

Please also write ChangeLog as

         * sysdeps/i386/start.S (_start): ...


-- 
H.J.

Follow-Ups:
- Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
  - From: Florian Weimer

References:
- [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
  - From: Terry Guo
- Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]