This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix C11 conformance issues

From: Joseph Myers <joseph at codesourcery dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, <libc-alpha at sourceware dot org>
Date: Wed, 25 Jul 2018 17:18:50 +0000
Subject: Re: [PATCH] Fix C11 conformance issues
References: <1532526205-5708-1-git-send-email-adhemerval.zanella@linaro.org> <2c759a06-b099-341b-60ac-06242259dc3b@redhat.com>

On Wed, 25 Jul 2018, Florian Weimer wrote:

> On 07/25/2018 03:43 PM, Adhemerval Zanella wrote:
> >   linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
> > -			   $(common-objpfx)nptl/libpthread.a
> > -linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
> > -			  $(common-objpfx)crypt/libcrypt.a
> > +			   $(static-thread-library)
> 
> I've just realized this:
> 
> Linking with the static thread library obscures linknamespace issues in libc.a
> for symbols which are also defined in libpthread.a.  So this change is a bit
> questionable.

The linknamespace code looks at every definition of a strong undefined 
symbol being resolved, not just the definition in a particular library.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] Fix C11 conformance issues
  - From: Florian Weimer

References:
- [PATCH] Fix C11 conformance issues
  - From: Adhemerval Zanella
- Re: [PATCH] Fix C11 conformance issues
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]