This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 10/12] Add another test for setcontext
On Wed, Jul 25, 2018 at 9:21 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/21/2018 04:20 PM, H.J. Lu wrote:
>>
>> + /* check sigmask in old context of swapcontext-call */
>> + if (sigismember (&oldctx.uc_sigmask, SIGUSR2) != 1)
>> + {
>> + puts ("FAIL: SIGUSR2 is not blocked in oldctx.uc_sigmask.");
>> + exit (1);
>> + }
>
>
> This breaks on ia64 because uc_sigmask does not have the correct type there:
>
> tst-setcontext4.c: In function ‘do_test’:
> tst-setcontext4.c:202:20: error: passing argument 1 of ‘sigismember’ from
> incompatible pointer type [-Werror=incompatible-pointer-types]
> if (sigismember (&oldctx.uc_sigmask, SIGUSR2) != 1)
> In file included from ../include/signal.h:2,
> from tst-setcontext4.c:23:
> ../signal/signal.h:208:41: note: expected ‘const sigset_t *’ {aka ‘const
> struct <anonymous> *’} but argument is of type ‘long unsigned int *’
> extern int sigismember (const sigset_t *__set, int __signo)
> ~~~~~~~~~~~~~~~~^~~~~
>
> I don't have a quick solution for this. How important is this part of the
> test?
>
I am testing this patch.
--
H.J.
From 70951c51d03623c10485380fcccd3a384dff20d6 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 25 Jul 2018 09:30:50 -0700
Subject: [PATCH] ia64: Work around incorrect type of IA64 uc_sigmask
* sysdeps/unix/sysv/linux/ia64/tst-setcontext4.c: New file.
---
.../unix/sysv/linux/ia64/tst-setcontext4.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 sysdeps/unix/sysv/linux/ia64/tst-setcontext4.c
diff --git a/sysdeps/unix/sysv/linux/ia64/tst-setcontext4.c b/sysdeps/unix/sysv/linux/ia64/tst-setcontext4.c
new file mode 100644
index 0000000000..58807e78cb
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/ia64/tst-setcontext4.c
@@ -0,0 +1,24 @@
+/* Work around incorrect type of IA64 uc_sigmask.
+ Copyright (C) 2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <signal.h>
+
+#undef sigismember
+#define sigismember(set, signo) sigismember ((const sigset_t *) (set), (signo))
+
+#include <stdlib/tst-setcontext4.c>
--
2.17.1