This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/12] x86: Update vfork to pop shadow stack


On 07/24/2018 08:25 AM, H.J. Lu wrote:
> On Mon, Jul 23, 2018 at 7:47 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 07/21/2018 10:20 AM, H.J. Lu wrote:
>>> Since we can't change return address on shadow stack, if shadow stack
>>> is in use, we need to pop shadow stack and jump back to caller directly.
>>>
>>>       * sysdeps/unix/sysv/linux/i386/vfork.S (SYSCALL_ERROR_HANDLER):
>>>       Redefine if shadow stack is enabled.
>>>       (SYSCALL_ERROR_LABEL): Likewise.
>>>       (__vfork): Pop shadow stack and jump back to to caller directly
>>>       when shadow stack is in use.
>>>       * sysdeps/unix/sysv/linux/x86_64/vfork.S (SYSCALL_ERROR_HANDLER):
>>>       Redefine if shadow stack is enabled.
>>>       (SYSCALL_ERROR_LABEL): Likewise.
>>>       (__vfork): Pop shadow stack and jump back to to caller directly
>>>       when shadow stack is in use.
>>> ---
>>>  sysdeps/unix/sysv/linux/i386/vfork.S   | 54 ++++++++++++++++++++++++++
>>>  sysdeps/unix/sysv/linux/x86_64/vfork.S | 35 +++++++++++++++++
>>>  2 files changed, 89 insertions(+)
>>
>> OK with comment suggestion.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>
> 
> This is what I checked in.
> 
> Thanks.
> 

Wrong patch?

c.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]