This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ucontext.h: Add __INDIRECT_RETURN
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 18 Jul 2018 20:58:56 +0000
- Subject: Re: [PATCH] ucontext.h: Add __INDIRECT_RETURN
- References: <20180718173558.GA18109@intel.com>
On Wed, 18 Jul 2018, H.J. Lu wrote:
> +#ifndef __INDIRECT_RETURN
> +# define __INDIRECT_RETURN
> +#endif
This default definition is missing a comment to define the semantics of
this macro. And please avoid this #ifndef convention. Rather, the normal
glibc convention would be to have e.g. a bits/indirect-return.h installed
header, with a default version with an empty definition and a comment
documenting the semantics, and a separate x86 version.
--
Joseph S. Myers
joseph@codesourcery.com