This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 11/12] Fix the ld flags not be applied to tst-execstack-mod.so
Joseph Myers <joseph@codesourcery.com> 於 2018年7月18日 週三 上午6:12寫道：
>
> On Tue, 17 Jul 2018, Zong Li wrote:
>
> > Fix the ld flags for applying the 'execstack' option correctly.
>
> Could you give a more detailed explanation? Presumably it's of the form
> that a particular file was intended to be linked with particular options,
> but that's ineffective because of the incorrect Makefile variable name.
>
> Please also include GNU-style ChangeLog entries with patch submissions.
OK, I will add the ChangeLog on next version.
> As with other such changes, I think this is not logically part of the new
> port and so should not be included in the patch series. However, it's the
> sort of safe bug fix that should be appropriate during the freeze, given a
> suitable commit message and ChangeLog entry.
>
OK, I will separate this patch. I think there is another patch
'[PATCH v2 12/12] Change URL of gcc's tarball' should be separate and
be included during the freeze, because it cannot obtain the new
version of gcc from ftp.
> --
> Joseph S. Myers
> joseph@codesourcery.com