This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/10] Optimized math routines


On 07/17/2018 05:59 PM, Joseph Myers wrote:
> On Fri, 6 Jul 2018, Szabolcs Nagy wrote:
> 
>> I think I addressed all of his comments in an acceptable way,
>> but i don't know if he had other concerns or if parts of the
>> code he has not reviewed yet.
> 
> The missing information in comments in previous versions effectively 
> prevented review of substantial parts of the code in those versions; 
> comments are critical information about the interfaces between different 
> parts of the code that are required for effective review (as well as for 
> subsequent maintainability of the code).
> 
> I think these changes are far too high risk for this late in the freeze.
 
Thanks for that review.

In which case let us defer to 2.29.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]