Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions

[Florian Weimer <fweimer at redhat dot com>]

On 07/12/2018 07:38 PM, Adhemerval Zanella wrote:
> On 12/07/2018 09:18, Florian Weimer wrote:
> > On 07/11/2018 06:24 PM, Adhemerval Zanella wrote:
> > > On 11/07/2018 12:49, Szabolcs Nagy wrote:
> > > > On 10/07/18 20:26, Adhemerval Zanella wrote:
> > > > > On 06/07/2018 09:46, Florian Weimer wrote:
> > > > > > On 02/02/2018 06:04 PM, Adhemerval Zanella wrote:
> > > > > > > @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \
> > > > > > >                    pthread_mutex_getprioceiling \
> > > > > > >                    pthread_mutex_setprioceiling \
> > > > > > >                    pthread_setname pthread_getname \
> > > > > > > -              pthread_setattr_default_np pthread_getattr_default_np
> > > > > > > +              pthread_setattr_default_np pthread_getattr_default_np \
> > > > > > > +              thrd_create thrd_current thrd_detach thrd_equal \
> > > > > >
> > > > > > thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet.
> > > > > >
> > > > > > Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well.
> > > > >
> > > > > Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and
> > > > > thrd_yield) to libc on my personal branch [1] (the change is just to move
> > > > > the objects from libpthread-routines to routines rule in nptl/Makefile).
> > > > > I also adjusted the abilist patch with the change.
> > > >
> > > > the abilist patch seems to add
> > > > sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist
> > > > i think you can drop that (and update the ChangeLog).
> > >
> > > Thanks for catching this up, I fixed on my personal c11 thread branch.
> >
> > I still see the attached ABI diffs.
>
> Thanks, I have corrected them in my personal branch, along with the ChangeLog
> entry and a lingering file from tile.

As of commit 2b9d7c41ade511d99cd917bb8d28eb0fe91971ed, I still see:

==> 
/home/bmg/build/glibcs/mipsel-linux-gnu-nan2008-soft/glibc/elf/check-abi-libc.out 
<==
--- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 
2018-07-10 08:15:53.536227638 -0400
+++ 
/home/bmg/build/glibcs/mipsel-linux-gnu-nan2008-soft/glibc/libc.symlist 
   2018-07-13 03:00:06.345221784 -0400
@@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F
+GLIBC_2.28 thrd_current F
+GLIBC_2.28 thrd_equal F
+GLIBC_2.28 thrd_sleep F
+GLIBC_2.28 thrd_yield F

==> 
/home/bmg/build/glibcs/mipsel-linux-gnu-soft/glibc/elf/check-abi-libc.out 
<==
--- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 
2018-07-10 08:15:53.536227638 -0400
+++ /home/bmg/build/glibcs/mipsel-linux-gnu-soft/glibc/libc.symlist 
2018-07-13 02:58:41.692589329 -0400
@@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F
+GLIBC_2.28 thrd_current F
+GLIBC_2.28 thrd_equal F
+GLIBC_2.28 thrd_sleep F
+GLIBC_2.28 thrd_yield F

==> 
/home/bmg/build/glibcs/mips-linux-gnu-nan2008-soft/glibc/elf/check-abi-libc.out 
<==
--- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 
2018-07-10 08:15:53.536227638 -0400
+++ 
/home/bmg/build/glibcs/mips-linux-gnu-nan2008-soft/glibc/libc.symlist 
   2018-07-13 03:00:43.831389053 -0400
@@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F
+GLIBC_2.28 thrd_current F
+GLIBC_2.28 thrd_equal F
+GLIBC_2.28 thrd_sleep F
+GLIBC_2.28 thrd_yield F

==> 
/home/bmg/build/glibcs/mips-linux-gnu-soft/glibc/elf/check-abi-libc.out <==
--- ../sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist 
2018-07-10 08:15:53.536227638 -0400
+++ /home/bmg/build/glibcs/mips-linux-gnu-soft/glibc/libc.symlist 
2018-07-13 03:00:32.210027180 -0400
@@ -1963,0 +1964,4 @@ GLIBC_2.28 statx F
+GLIBC_2.28 thrd_current F
+GLIBC_2.28 thrd_equal F
+GLIBC_2.28 thrd_sleep F
+GLIBC_2.28 thrd_yield F

Florian