This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/2] libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: libc-alpha at sourceware dot org, Florian Weimer <fweimer at redhat dot com>, Alan Modra <amodra at gmail dot com>
- Date: Thu, 5 Jul 2018 14:02:12 -0400
- Subject: Re: [PATCH v2 2/2] libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307]
- References: <alpine.DEB.2.00.1806181533590.20622@tp.orcam.me.uk> <alpine.DEB.2.00.1806181810570.20622@tp.orcam.me.uk> <87sh5a38tz.fsf@mid.deneb.enyo.de> <alpine.DEB.2.00.1806261348560.20622@tp.orcam.me.uk> <d1ee54d8-9491-28cb-3fcf-b13408d47b6a@redhat.com> <alpine.DEB.2.00.1806280905490.20622@tp.orcam.me.uk> <d6680b9a-2afe-7801-c923-0bdceb736950@redhat.com> <alpine.DEB.2.00.1806281516050.20622@tp.orcam.me.uk> <alpine.DEB.2.00.1806291721220.20622@tp.orcam.me.uk> <87b6fb82-09cf-e79c-79a4-281a0a297a64@redhat.com> <alpine.DEB.2.00.1807051517290.22261@tp.orcam.me.uk> <56d6a870-7caa-5f55-81fd-4565525a36ed@redhat.com> <alpine.DEB.2.00.1807051745560.22261@tp.orcam.me.uk>
On 07/05/2018 01:09 PM, Maciej W. Rozycki wrote:
> Hi Carlos,
>
>>> +* The GNU C Library now has correct support for ABSOLUTE symbols
>>> + (SHN_ABS-relative symbols). Previously such ABSOLUTE symbols were
>>> + relocated incorrectly or in some cases discarded. The GNU linker can
>>> + make use of this newer semantics, but it must communicate it to the
>>
>> Suggest:
>> "make use of the corrected semantics, ..."
>
> Hmm, "semantics" is uncountable rather than plural[1], so I'm not sure if
> "this semantics" is actually a grammatical mistake (just like "Can I drink
> this milk?" is fine), but I'm fine with your suggestion. I actually
> considered using "the" to avoid having this discussion. ;)
The use of 'the' with countable nouns is allowed when they refer to a
specific example, like in this case, and I find English speakers prefer
this form.
You are correct though, it's not a grammatical mistake to use 'this'
with the uncounted noun, I had forgotten about this completely.
Thank you for elightening me! :-)
> Committed with your suggestion applied then. Thank you for your review.
My key motivation was to avoid the use of "newer" since this temporal
reference becomes difficult to understand at a later time and
"corrected" is, well, always correct.
--
Cheers,
Carlos.