This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6 1/3] Tunables: Add tunables of spin count for pthread adaptive spin mutex
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: kemi <kemi dot wang at intel dot com>
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Florian Weimer <fweimer at redhat dot com>, Rical Jason <rj at 2c3t dot io>, Carlos Donell <carlos at redhat dot com>, Glibc alpha <libc-alpha at sourceware dot org>, Dave Hansen <dave dot hansen at linux dot intel dot com>, "Chen, Tim C" <tim dot c dot chen at intel dot com>, "Kleen, Andi" <andi dot kleen at intel dot com>, "Huang, Ying" <ying dot huang at intel dot com>, "Lu, Aaron" <aaron dot lu at intel dot com>, "Li, Aubrey" <aubrey dot li at intel dot com>
- Date: Wed, 4 Jul 2018 19:16:08 -0700
- Subject: Re: [PATCH v6 1/3] Tunables: Add tunables of spin count for pthread adaptive spin mutex
- References: <1530520046-18343-1-git-send-email-kemi.wang@intel.com> <CAMe9rOopnM=io7k9z4a2LzjuYZMtwH8xUuNbRMLcTTLzHBeCYA@mail.gmail.com> <CAMe9rOrtBocsbRtdG6M9=A=KQu8HbZ=1gj8=hJ=hZZnOiS3WJA@mail.gmail.com> <4ded0d74-a02d-7bb3-ab57-befa981e86c2@intel.com> <25017BF213203E48912DB000DE5F5E1E6B82EFB5@SHSMSX101.ccr.corp.intel.com> <CAMe9rOq0FXYqNHq2BovpzHPPjYNVPPEEy60TRfzkLb2H9DV+uA@mail.gmail.com> <6c1a5a6c-ac23-bab1-e865-f0bbfdd77694@intel.com>
On Wed, Jul 4, 2018 at 6:27 PM, kemi <kemi.wang@intel.com> wrote:
>
>
> On 2018年07月04日 21:16, H.J. Lu wrote:
>> On Tue, Jul 3, 2018 at 10:55 PM, Wang, Kemi <kemi.wang@intel.com> wrote:
>>> BTW, do I need to submit v7 to fold these change?
>>>
>>
>> Please submit 2 sets of patches:
>>
>
> Sure. Thanks for your time to help review!
>
>> 1. Make MAX_ADAPTIVE_COUNT tunable. Are there any future tunable
>> candidates in libpthread?
>
> The one which uses MCS lock to queue spinner to improve the performance
> of adaptive mutex may be tunable in future.
> Currently, it is pending review.
This tunable is specific to pthread. Please place it in
nptl/dl-tunables.list with
pthread namespace. See sysdeps/x86/dl-tunables.list for an example.
> https://sourceware.org/ml/libc-alpha/2018-07/msg00005.html
> https://sourceware.org/ml/libc-alpha/2018-07/msg00008.html
> https://sourceware.org/ml/libc-alpha/2018-07/msg00009.html
> https://sourceware.org/ml/libc-alpha/2018-07/msg00007.html
> https://sourceware.org/ml/libc-alpha/2018-07/msg00006.html
>
>> 2. Add atomic_spin_lock.
>>
>> These should be independent of each other.
>>
>>
--
H.J.