This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix path length overflow in realpath (BZ#22786)
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 08 May 2018 15:45:32 +0000
- Subject: Re: [patch] Fix path length overflow in realpath (BZ#22786)
- References: <CALoOobOyeu6SM7DGPRqmHE6Y7BckFGmEFGeeFKDKjskL4EJDuA@mail.gmail.com> <alpine.DEB.2.20.1804172059000.1402@digraph.polyomino.org.uk> <CALoOobNywsKOoamnNH7=eF28=yoQMsFPy+5O6cgD4oqpVDhARA@mail.gmail.com> <mvmzi1a5h39.fsf@suse.de> <CALoOobNzPmK+5fnxF-cFhkGjOuemGaa3GepJZnb_1m38wb-1xA@mail.gmail.com> <mvmvaby5fnz.fsf@suse.de>
On Tue, May 8, 2018 at 8:29 AM Andreas Schwab <schwab@suse.de> wrote:
> > The (stack) allocated buffer is large enough
> Is it? The condition is about the limit of the buffer being written,
> and about overflow missing the limit.
Oops, I mixed up this patch with the other overflow (BZ 20419).
You are absolutely right. Will retest and commit shortly.
Thanks,
--
Paul Pluzhnikov