This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/11] nds32: Build Infastructure
On Sun, 6 May 2018, vincentc wrote:
> diff --git a/sysdeps/nds32/configure.ac b/sysdeps/nds32/configure.ac
> new file mode 100644
> index 0000000..4ca57b8
> --- /dev/null
> +++ b/sysdeps/nds32/configure.ac
> @@ -0,0 +1,14 @@
> +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
> +# Local configure fragment for sysdeps/nds32.
> +CFLAGS="$CFLAGS -minline-asm-r15"
If that option is needed globally for building glibc, a comment should be
there to explain it.
> +AC_CACHE_CHECK(whether gcc support option -mno-scalbn-transform,
> + libc_cv_scalbn_transform, [dnl
> +save_CFLAGS="$CFLAGS"
> +CFLAGS="$CFLAGS -mno-scalbn-transform"
What does this option do (I don't see it in current GCC)? Since you've
said current GCC versions aren't suitable for building glibc, can't you
just require a compiler supporting the option, unconditionally, so any
test for it is just to ensure a configure error for a too-old compiler
rather than allowing compilation to continue without support?
--
Joseph S. Myers
joseph@codesourcery.com