This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 03/21] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Zack Weinberg <zackw at panix dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sun, 6 May 2018 22:48:04 -0400
- Subject: Re: [PATCH v2 03/21] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- References: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> <1519679016-12241-4-git-send-email-adhemerval.zanella@linaro.org> <CAKCAbMimSmhtEFp4=9ts=wB=6=-MZvxr-fWQDBsVj4g=jV29ag@mail.gmail.com> <4141f1f5-c4b2-f94c-6fe2-b961f5e3ee8a@linaro.org>
On Fri, Apr 27, 2018 at 8:25 AM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> On 27/04/2018 09:20, Zack Weinberg wrote:
>> On Mon, Feb 26, 2018 at 4:03 PM, Adhemerval Zanella
>> <adhemerval.zanella@linaro.org> wrote:
>>> This patches fixes some race conditions in NPTL cancellation code by
>>> redefining how cancellable syscalls are defined and handled. Current
>>> approach is to enable asynchronous cancellation prior to making the syscall
>>> and restore the previous cancellation type once the syscall returns.
>>
>> Did these patches ever get reviewed/committed? #12683 has been
>> festering for a long time...
>
> Thanks for bring this up. No, I haven't received any review so far about it.
Let's try to unjam this. I will post reviews for patches 1, 2, 3, 4,
and 6 shortly. Unfortunately, all of the other patches require review
by architecture experts; I don't know enough about the low-level ABI
details for anything other than plain x86-32 and -64.
zw