This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] x86-64/swapcontext: Restore the pointer into %rdx after syscall
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 2 May 2018 01:04:02 -0400
- Subject: Re: [PATCH 2/2] x86-64/swapcontext: Restore the pointer into %rdx after syscall
- Openpgp: preference=signencrypt
- References: <20180426121744.GB30766@intel.com> <09599cf2-6eca-1052-1788-35dd3b2e5225@redhat.com>
On 04/29/2018 05:10 PM, Florian Weimer wrote:
> On 04/26/2018 02:17 PM, H.J. Lu wrote:
>> + /* Restore destroyed register into RDX which is preserved by
>> + the syscall. */
>> + movq %r12, %rdx
>
> Again, this comment does not make sense without the other upcoming changes.
OK with my suggestion for comment in 1/2 of this series.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.