This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: riscv: fmax/fmin sNaN fix
- From: DJ Delorie <dj at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 21 Feb 2018 19:24:42 -0500
- Subject: Re: riscv: fmax/fmin sNaN fix
- Authentication-results: sourceware.org; auth=none
"Carlos O'Donell" <carlos@redhat.com> writes:
> Patch review includes review of the commit messages for factual accuracy.
Please review the original changelog entry then ;-)
> * sysdeps/riscv/rvd/s_fmax.c (__fmax): Handle sNaNs correctly.
> * sysdeps/riscv/rvd/s_fmin.c (__fmin): Likewise.
> * sysdeps/riscv/rvf/s_fmaxf.c (__fmaxf): Likewise.
> * sysdeps/riscv/rvf/s_fminf.c (__fminf): Likewise.
That's actually functional, and doesn't mention anything about specs,
should be sufficient.
Original author: Andrew Waterman <andrew@sifive.com>
(plus or minus the "maintainers have automatic consensus" rules, of
course ;)