This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][AArch64] Use builtins for fpcr/fpsr

From: Joseph Myers <joseph at codesourcery dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Mon, 12 Feb 2018 14:02:07 +0000
Subject: Re: [PATCH][AArch64] Use builtins for fpcr/fpsr
Authentication-results: sourceware.org; auth=none
References: <DB6PR0801MB20530C40FDB2D3561E6728BC83100@DB6PR0801MB2053.eurprd08.prod.outlook.com>,<5A60A7BF.6090000@arm.com>,<DB6PR0801MB20535C53FE803D3DD74A695083EF0@DB6PR0801MB2053.eurprd08.prod.outlook.com> <DB6PR0801MB20535E76ABF67E12E616C0F083F20@DB6PR0801MB2053.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1802092233190.21892@digraph.polyomino.org.uk> <DB6PR0801MB2053CB04CA77D6D39EB97E5783F10@DB6PR0801MB2053.eurprd08.prod.outlook.com>

On Sat, 10 Feb 2018, Wilco Dijkstra wrote:

> Joseph Myers wrote:
>   
> In file included from ../include/fpu_control.h:2:0,
>                  from test-fpucw.c:19:
> ../sysdeps/aarch64/fpu/fpu_control.h:24:5: error: "__GNUC_PREREQ" is not defined, evaluates to 0 [-Werror=undef]
> 
> > fpu_control.h is missing an include of features.h, as needed to use 
> > __GNUC_PREREQ.
> 
> Yes, I added the include but forgot to merge it with the patch. Now committed.

Normal practice in glibc installed headers (and more generally in glibc) 
is to use #include <>, not #include "" as in that change.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- Re: [PATCH][AArch64] Use builtins for fpcr/fpsr
  - From: Wilco Dijkstra
- Re: [PATCH][AArch64] Use builtins for fpcr/fpsr
  - From: Joseph Myers
- Re: [PATCH][AArch64] Use builtins for fpcr/fpsr
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]