This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/6] Remove miscellaneous debris from libio.
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: libc-alpha at sourceware dot org, fweimer at redhat dot com, adhemerval dot zanella at linaro dot org
- Date: Sun, 11 Feb 2018 19:07:31 +0100
- Subject: Re: [PATCH 5/6] Remove miscellaneous debris from libio.
- Authentication-results: sourceware.org; auth=none
- References: <20180211163558.14124-1-zackw@panix.com> <20180211163558.14124-6-zackw@panix.com>
On Feb 11 2018, Zack Weinberg <zackw@panix.com> wrote:
> diff --git a/libio/fileops.c b/libio/fileops.c
> index fb39bec63cd..618c0d5c311 100644
> --- a/libio/fileops.c
> +++ b/libio/fileops.c
> @@ -468,11 +468,6 @@ int
> _IO_new_file_underflow (FILE *fp)
> {
> ssize_t count;
> -#if 0
> - /* SysV does not make this test; take it out for compatibility */
> - if (fp->_flags & _IO_EOF_SEEN)
> - return (EOF);
> -#endif
AFAICS, this is an area where we are not conforming to the C standard
(the EOF indicator is supposed to be sticking, see fgetc, and only
clearerr can fix that).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."