This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] aarch64: Revert the change of the __reserved member of mcontext_t
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Joseph Myers <joseph at codesourcery dot com>, Romain Naour <romain dot naour at gmail dot com>
- Date: Wed, 24 Jan 2018 11:55:51 +0000
- Subject: Re: [PATCH] aarch64: Revert the change of the __reserved member of mcontext_t
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <5A674841.9040007@arm.com> <6e16d049-d1bb-7b73-3b4d-75850de8264a@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 23/01/18 15:16, Florian Weimer wrote:
> On 01/23/2018 03:35 PM, Szabolcs Nagy wrote:
>> The uc_mcontext.__reserved member of ucontext_t is a user visible API,
>> that should not be changed, because this is the only way to access cpu
>> states of various extensions of linux asm/sigcontext.h, it does not
>> violate namespace rules either, so revert this part of the commit
>>
>> commit 4fa9b3bfe6759c82beb4b043a54a3598ca467289
>> Commit: Joseph Myers<joseph@codesourcery.com>
>>
>> Fix mcontext_t sigcontext namespace (bug 21457).
>>
>> (In principle the user can type cast &uc_mcontext to struct sigcontext*
>> to use the linux sigcontext fields, but that's not the existing practice
>> since mcontext_t used to be a typedef of struct sigcontext.)
>>
>> I plan to commit this soon for 2.27 and backport it to 2.26 if there are
>> no comments.
>
> I think this is the right thing to do, but unfortunately, this back-and-forth is a bit painful.
>
ok, i opened bug 22742 because it's a user visible change.
committed now on 2.27 (will backport it in a day or two).