This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

TODO: Alternative month names (was: Re: glibc 2.27: less than two weeks till release)


18.01.2018 18:56 "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> [...]
> ** Month names in alternative grammatical case[4]
>
> This has already been reviewed by Carlos.
> Rafal, is there anything that has to be done before these series is committed?
> [...]
> [4] https://sourceware.org/ml/libc-alpha/2018-01/msg00258.html
> [...]

I posted the 12th version of the patches for the final review [5]
because of some changes in the documentation and test cases.
Carlos answered that he'd verify the compatibility of statically
built binaries before giving the final OK [6] but he did not yet.
In the meantime I did a simple test and stated that the old static
library is unable to load any new binary locale data. [7][8] My test
was very cursory, that means I did not test what actually failed
and whether the problem is really impossible to resolve, I only guess
this is because of some sanity tests which verify the size of the
binary data and expect it to be equal to the size defined by their
version of glibc.  Florian agreed that even if it is not compatible
the problem is not blocking. [9] Joseph Myers said that this
incompatibility is acceptable and this already had happened in the
past but needs to be mentioned in NEWS. [10][11] This NEWS section
does not exist yet, though.

Rical Jasan provided his own review. [12] He has many documentation
remarks but I applied locally only one (reword "month name" to
"month names") because I am not sure that other changes should be
applied.  OTOH, if anybody wants to update the documentation after
I push the patches to master you are most welcome. That may be
even easier than telling me what I should fix locally, waiting
for another post etc.  Rical also suggests that instead of
_NL_ABALTMON_* pattern I should use __ABALTMON_* and conditionally
#ifdef __USE_GNU #define ABALTMON_*.  Again, I am not sure if
this is the right moment.  Of course, we indeed can add these
symbols in the future.  See also: [13] Note: _NL_WABALTMON_* should
remain, same as _NL_WMON_* and _NL_WABMON_*.

Please note that in order for these patches to be really useful
we still need the actual data to be updated and I'd like to contact
translators before I push the locale data changes.  So far I have
contacted only pl_PL translator and got the permission.  I think
it does not make sense to contact the translators before the patches
are pushed.

Regards,

Rafal


[5] https://sourceware.org/ml/libc-alpha/2018-01/msg00433.html
[6] https://sourceware.org/ml/libc-alpha/2018-01/msg00494.html
[7] https://sourceware.org/ml/libc-alpha/2018-01/msg00496.html
[8] https://sourceware.org/ml/libc-alpha/2018-01/msg00592.html
[9] https://sourceware.org/ml/libc-alpha/2018-01/msg00594.html
[10] https://sourceware.org/ml/libc-alpha/2018-01/msg00463.html
[11] https://sourceware.org/bugzilla/show_bug.cgi?id=19084
[12] https://sourceware.org/ml/libc-alpha/2018-01/msg00497.html
[13] http://austingroupbugs.net/view.php?id=1166


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]