This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 13/18] hppa: Add memcopy.h


On 12/01/2018 16:17, Joseph Myers wrote:
> On Fri, 12 Jan 2018, Adhemerval Zanella wrote:
> 
>>>> +  if (OPSIZ == 4)
>>>> +    asm("shrpw %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
>>>> +  else if (OPSIZ == 8)
>>>> +    asm("shrpd %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
>>>> +  else
>>>> +    link_error(), res = 0;
>>>
>>> Likewise, after asm, and after link_error, and after strings in asm.
>>>
>>
>> I fixed all locally.
> 
> (Some of the other patches were also similarly missing spaces after asm 
> constraint strings.)
> 

Thanks, I will double check it (I used Richard's version unchanged).
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]