This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Minimize use of _IO_ and _G_ symbols in public headers.


On Tue, 26 Dec 2017, Zack Weinberg wrote:

> +* The C++ name mangling for interfaces involving the types fpos_t and
> +  fpos64_t has changed.

I don't think this change is appropriate, since it's in no way necessary 
for correctness or to achieve the cleanup.  (You could call the types 
"struct _G_fpos_t" and "struct _G_fpos64_t" to avoid changing the mangling 
while still breaking any C code that wrongly uses _G_fpos_t or 
_G_fpos64_t, and still use only the typedefs __fpos_t / __fpos64_t 
directly in glibc.  If we did wish to break the mangling we should fix bug 
15766 while doing so, but really I think the right way to address that bug 
is not to change mangling but to move to _FILE_OFFSET_BITS=64 by default 
so the _FILE_OFFSET_BITS=32 ABI becomes irrelevant.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]