This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/3] tst-realloc: do not check for errno on success [BZ #22611]

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: Aurelien Jarno <aurelien at aurel32 dot net>
Cc: libc-alpha at sourceware dot org
Date: Fri, 29 Dec 2017 15:39:34 +0300
Subject: Re: [PATCH v2 1/3] tst-realloc: do not check for errno on success [BZ #22611]
Authentication-results: sourceware.org; auth=none
References: <20171222193101.3396-1-aurelien@aurel32.net> <20171222193101.3396-2-aurelien@aurel32.net>

On Fri, Dec 22, 2017 at 08:30:59PM +0100, Aurelien Jarno wrote:
> POSIX explicitly says that applications should check errno only after
> failure, so the errno value can be clobbered on success as long as it
> is not set to zero.

The trailing part "as long as it is not set to zero." sounds confusing
in this context, I think "the errno value can be clobbered on success."
is good enough by itself.

The patch is fine, please commit.

-- 
ldv

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH v2 0/3]
  - From: Aurelien Jarno
- [PATCH v2 1/3] tst-realloc: do not check for errno on success [BZ #22611]
  - From: Aurelien Jarno

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]