This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
On Tue, Dec 26, 2017 at 02:07:45PM +0100, Florian Weimer wrote:
> * Dmitry V. Levin:
> > On Mon, Dec 25, 2017 at 12:09:56PM -0800, Zack Weinberg wrote:
> >> On Mon, Dec 25, 2017 at 11:12 AM, Dmitry V. Levin <email@example.com> wrote:
> >> > On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote:
> >> >> * Dmitry V. Levin:
> >> >>
> >> >> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the
> >> >> > test instead of failing in case of an error returned by posix_openpt.
> >> >>
> >> >> I think the test failure is real in this case. I wouldn't it be?
> >> >
> >> > No, /dev/ptmx is intentionally missing in the environment where this test
> >> > failed.
> >> Why?
> > It's a restricted environment.
> I don't think the glibc test suite is supposed to pass in such an
It used to work perfectly for at least 15 years, and it still works
when tst-ttyname is fixed.
> If you don't provide /dev/null, /sys, or /proc to the
> tests, some of them will fail as well.
This is irrelevant to /dev/ptmx availability.
> I still think that the current
> test accurately reflects the inadequacy of your test environment.
I do not agree.
btw, as support_become_root is also unavailable in restricted
environments, an alternative fix for tst-ttyname is to skip the test
when support_become_root fails.