This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
* Dmitry V. Levin:
> On Mon, Dec 25, 2017 at 12:09:56PM -0800, Zack Weinberg wrote:
>> On Mon, Dec 25, 2017 at 11:12 AM, Dmitry V. Levin <email@example.com> wrote:
>> > On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote:
>> >> * Dmitry V. Levin:
>> >> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the
>> >> > test instead of failing in case of an error returned by posix_openpt.
>> >> I think the test failure is real in this case. I wouldn't it be?
>> > No, /dev/ptmx is intentionally missing in the environment where this test
>> > failed.
> It's a restricted environment.
I don't think the glibc test suite is supposed to pass in such an
environment. If you don't provide /dev/null, /sys, or /proc to the
tests, some of them will fail as well. I still think that the current
test accurately reflects the inadequacy of your test environment.