This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 02/15] RISC-V: ABI Implementation

On Wed, 20 Dec 2017 08:31:11 PST (-0800), wrote:
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:


Should have space before '(' in such a macro call.




Likewise.  Please check and fix this throughout this patch series.

+ * Macros to handle different pointer/register sizes for 32/64-bit code
+ */

GNU-style macros should not have the leading '*' on each line; please fix
throughout this file and anywhere else affected in this patch series.
Also, comments on macros or functions should generally not name the macro
or function being described, so e.g. "Declare leaf routine." (or "Declare
leaf routine SYMBOL.") not "LEAF - declare leaf routine".

+	     : "=r"(__result));				\

Missing space before '(', and similarly in other TLS macros.

+	__tls_get_addr(__result); })

Likewise, and similarly in other TLS macros.

Thanks. I believe I've fixed them all, but I'm not 100% sure. Is there a script I can run to check this? Something like in Linux? I poked around Google a bit and couldn't find anything.

I also have one style question: I noticed that

  #define macro(x) ...
  macro (x)

 void func (int x)
 func (x)

don't appear to be consistent, but a grep through the glibc code base seems to indicate that's the way things are going. Did I miss something?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]