This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2 02/15] RISC-V: ABI Implementation
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: joseph at codesourcery dot com
- Cc: libc-alpha at sourceware dot org, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, dj at redhat dot com
- Date: Fri, 22 Dec 2017 19:24:57 -0800 (PST)
- Subject: Re: [PATCH v2 02/15] RISC-V: ABI Implementation
- Authentication-results: sourceware.org; auth=none
On Wed, 20 Dec 2017 08:31:11 PST (-0800), firstname.lastname@example.org wrote:
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
Should have space before '(' in such a macro call.
Likewise. Please check and fix this throughout this patch series.
+ * Macros to handle different pointer/register sizes for 32/64-bit code
GNU-style macros should not have the leading '*' on each line; please fix
throughout this file and anywhere else affected in this patch series.
Also, comments on macros or functions should generally not name the macro
or function being described, so e.g. "Declare leaf routine." (or "Declare
leaf routine SYMBOL.") not "LEAF - declare leaf routine".
+ : "=r"(__result)); \
Missing space before '(', and similarly in other TLS macros.
+ __tls_get_addr(__result); })
Likewise, and similarly in other TLS macros.
Thanks. I believe I've fixed them all, but I'm not 100% sure. Is there a
script I can run to check this? Something like checkpatch.pl in Linux? I
poked around Google a bit and couldn't find anything.
I also have one style question: I noticed that
#define macro(x) ...
void func (int x)
don't appear to be consistent, but a grep through the glibc code base seems to
indicate that's the way things are going. Did I miss something?