This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/3] elf: remove is_path related redundant code
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: libc-alpha at sourceware dot org
- Date: Wed, 20 Dec 2017 21:21:00 +0100
- Subject: Re: [PATCH 0/3] elf: remove is_path related redundant code
- Authentication-results: sourceware.org; auth=none
- References: <20171220134238.GC20476@altlinux.org>
On 2017-12-20 16:42, Dmitry V. Levin wrote:
> The only place in the code nowadays that specifies is_path == 1 argument
> is fillin_rpath, and the string being passed in that case never contains ':'
> symbols. This makes the whole is_path thing redundant.
>
> Dmitry V. Levin (3):
> elf: remove redundant code from _dl_dst_substitute
> elf: remove redundant code from is_dst
> elf: remove redundant is_path argument
>
> ChangeLog | 15 ++++++++++++
> elf/dl-deps.c | 4 +--
> elf/dl-dst.h | 4 +--
> elf/dl-load.c | 61 ++++++++++++++--------------------------------
> sysdeps/generic/ldsodefs.h | 4 +--
> 5 files changed, 39 insertions(+), 49 deletions(-)
This looks all good to me, thanks for the cleanup.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net