This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/3] Cleanup __ieee754_sqrt(f/l)

On Wed, 20 Dec 2017, Wilco Dijkstra wrote:

> Build & test OK on AArch64.

I think the general design is right, but I also think this really needs a test run (as do subsequent patches moving calls to 
use sqrt/sqrtf/sqrtl directly) because of the high risk of 
architecture-specific breakage.

(Direct calling of sqrtf128 with similar redirects to those for sqrt / 
sqrtf / sqrtl is also appropriate: GCC 8 has it as a built-in function so 
can inline calls with -fno-math-errno on powerpc64le for POWER9.  So the 
patch should include a sqrtf128 redirect if __HAVE_DISTINCT_FLOAT128.)

> diff --git a/math/w_sqrt_template.c b/math/w_sqrt_template.c
> index 5fae302382d10e9b05df2665c9cb05126cd62f02..235c263e60c85422e41bca7c817148b66030438f 100644
> --- a/math/w_sqrt_template.c
> +++ b/math/w_sqrt_template.c
> @@ -21,6 +21,7 @@
>     for each floating-point type.  */

Missing preprocessor indentation, "# define".

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]