This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2 07/15] RISC-V: RV32F Support
On Wed, 20 Dec 2017, Joseph Myers wrote:
> On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> > + int nan = isnanf (x);
> I don't think any libm code should be using the legacy X/Open
> type-specific classification functions such as isnanf. Use the C99
> type-generic macros such as isnan instead.
Also, and again in patch 8: I think new code should preferably use bool
(from <stdbool.h>) for boolean variables like this, instead of int.
Joseph S. Myers