This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 07/15] RISC-V: RV32F Support
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, <dj at redhat dot com>
- Date: Wed, 20 Dec 2017 17:01:28 +0000
- Subject: Re: [PATCH v2 07/15] RISC-V: RV32F Support
- Authentication-results: sourceware.org; auth=none
- References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-8-palmer@dabbelt.com>
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> + int nan = isnanf (x);
I don't think any libm code should be using the legacy X/Open
type-specific classification functions such as isnanf. Use the C99
type-generic macros such as isnan instead.
> + int nan = isnanf (x);
Likewise, and again throughout this patch.
--
Joseph S. Myers
joseph@codesourcery.com