This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp

On Tue, Dec 19, 2017 at 8:41 AM, H.J. Lu <> wrote:
>>> That doesn't seem to be one of the patches you listed as a dependency of
>>> this one.  Does that not matter because __SHSTK__ can never be defined
>>> when building glibc unless that other patch is in glibc?
>> I submitted the setjmp patch to show how backward binary compatibility
>> is preserved.   Yes, setjmp is unchanged if we aren't building glibc with
>> CET enabled, which will be done in a separate patch.
> As I mentioned, we need room in jmp_buf to save and restore shadow stack
> pointer in setjmp/longjmp.  Since only Linux/x86 jmp_buf has a space for
> shadow stack pointer, this setjmp/longjmp patch is only for Linux/x86.
> I am checking it in today.

I don't think you have consensus. You haven't answered most of
Joseph's questions, and it is not clear to me whether Florian
considers his objection resolved.  This is not a high-priority bugfix.
Please stop trying to rush it in.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]