This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v10 1/5] Implement alternative month names (bug 10871).


16.11.2017 12:44 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> [...]
> [BZ #10871]
> * locale/C-time.c: Add alternative month names, define them as the
> same as mon explicitly.
> * locale/categories.def: alt_mon and wide-alt_mon added.
> * locale/langinfo.h [__USE_GNU]: New public symbols ALTMON_1,
> ALTMON_2, ALTMON_3, ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7,
> ALTMON_8, ALTMON_9, ALTMON_10, ALTMON_11, ALTMON_12,
> _NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3, _NL_WALTMON_4,
> _NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7, _NL_WALTMON_8,
> _NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11, _NL_WALTMON_12.

Having thought about it a while and read some changelog writing
guide I think this list should be split like that:

* locale/langinfo.h: New public symbols _NL_WALTMON_1,
_NL_WALTMON_2, _NL_WALTMON_3, _NL_WALTMON_4, _NL_WALTMON_5,
_NL_WALTMON_6, _NL_WALTMON_7, _NL_WALTMON_8, _NL_WALTMON_9,
_NL_WALTMON_10, _NL_WALTMON_11, _NL_WALTMON_12.
[__USE_GNU]: New public symbols ALTMON_1, ALTMON_2, ALTMON_3,
ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7, ALTMON_8, ALTMON_9,
ALTMON_10, ALTMON_11, ALTMON_12.

What do you think?

Also I think that the documentation should be reviewed again [1].
Of course review of whole patchset is welcome. [2] [3]

Regards,

Rafal


[1] https://sourceware.org/ml/libc-alpha/2017-11/msg00572.html
[2] https://sourceware.org/ml/libc-alpha/2017-11/msg00570.html
[3] https://sourceware.org/ml/libc-alpha/2017-11/msg00571.html


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]