This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v3] New generic cosf
Paul Clarke <firstname.lastname@example.org> writes:
> On 12/07/2017 11:59 AM, H.J. Lu wrote:
>> On Thu, Dec 7, 2017 at 9:07 AM, Paul Clarke <email@example.com> wrote:
>>> The same logic used in s_cosf.S version for x86 and powerpc
>>> is used to create a generic s_cosf.c, so there is no performance
>>> improvement in x86_64 and powerpc64.
>>> 2017-12-06 Paul A. Clarke <firstname.lastname@example.org>
>>> * sysdeps/ieee754/flt-32/s_cosf.c: New implementation.
>> Please take a look at sysdeps/ieee754/flt-32/math_config.h to see how
>> to share constants between s_cosf.c and s_sinf.c.
> I interpreted Joseph's response to your earlier suggestion of the same as it to be acceptable to common these tables and constants into a future submission of a combined sinf/cosf/sincosf.
> Raji is looking into that approach.
> As for cosf, I figured committing a good cosf now is better than waiting for a perfect sinf/cosf/sincosf. Unless there are strong objections?
Pushed as f4b2aea6e133.