This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Add sinf with FMA



On 04/12/2017 16:09, H.J. Lu wrote:
> On Skylake, bench-sinf reports performance improvement:
> 
>             Before        After         Improvement
> max        153.996       100.094           54%
> min        8.546         6.852             25%
> mean       18.1223       14.4616           25%
> 
> Any comments?
> 
> H.J.
> ---
> 	* sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines):
> 	Add s_sinf-sse2 and s_sinf-fma.
> 	(CFLAGS-s_sinf-fma.c): New.
> 	* sysdeps/x86_64/fpu/s_sinf.S (sinf): Add alias only if __sinf
> 	is undefined.
> 	* sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c: New file.
> 	* sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S: Likewise.
> 	* sysdeps/x86_64/fpu/multiarch/s_sinf.c: Likewise.
> ---
>  sysdeps/x86_64/fpu/multiarch/Makefile      |  5 ++++-
>  sysdeps/x86_64/fpu/multiarch/s_sinf-fma.c  |  3 +++
>  sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.S |  3 +++

With new s_sinf.c generic implementation, does x86_64 still require an 
assembly one?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]