This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times
- From: Arnd Bergmann <arnd at arndb dot de>
- To: "Eric W. Biederman" <ebiederm at xmission dot com>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, John Stultz <john dot stultz at linaro dot org>, Thomas Gleixner <tglx at linutronix dot de>, y2038 Mailman List <y2038 at lists dot linaro dot org>, GNU C Library <libc-alpha at sourceware dot org>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, linux-arch <linux-arch at vger dot kernel dot org>, Linux API <linux-api at vger dot kernel dot org>, Albert ARIBAUD <albert dot aribaud at 3adev dot fr>, Richard Henderson <rth at twiddle dot net>, Ivan Kokshaysky <ink at jurassic dot park dot msu dot ru>, Matt Turner <mattst88 at gmail dot com>, Al Viro <viro at zeniv dot linux dot org dot uk>, Ingo Molnar <mingo at kernel dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, Deepa Dinamani <deepa dot kernel at gmail dot com>, Greg Kroah-Hartman <gregkh at linuxfoundation dot org>, Oleg Nesterov <oleg at redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, Kirill Tkhai <ktkhai at virtuozzo dot com>, linux-alpha at vger dot kernel dot org
- Date: Tue, 28 Nov 2017 11:32:06 +0100
- Subject: Re: [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times
- Authentication-results: sourceware.org; auth=none
- References: <20171127170121.634826-1-arnd@arndb.de> <20171127170121.634826-3-arnd@arndb.de> <34369a6e-e0ce-fe7b-65e3-9c4a33e4789a@cs.ucla.edu> <87o9nnlfpq.fsf@xmission.com> <CAK8P3a1asMLnJtea=JkduiYzr0dF0BTKQzcx5aQVv1zU5dK2FA@mail.gmail.com>
On Mon, Nov 27, 2017 at 9:41 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> One argument for using c) plus the emulation in glibc is that glibc
> has to do emulation anyway, to allow running user space with 64-bit
> time_t on older kernels that don't have the new getrusage system
> call.
To clarify my point here, if we stay with approach c), I think it should work
directly with the Albert's proposed patch "Y2038: add function
__getrusage_t64" [1], and we can remove the " // TODO: use
64-bit-time syscall if available" there. If we pick approach b), we
still need the same glibc patch, but would also implement the
interface to the new system call. As Eric said, this would be slightly
cleaner, but not really help us since 32-bit fields in rusage are
sufficient on the kernel interface side.
Arnd
[1] https://patchwork.ozlabs.org/patch/811246/