This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] support: Add TEST_COMPARE macro
On 11/27/2017 07:00 PM, Paul Eggert wrote:
Come to think of it, perhaps it would be easier to add -Wsign-compare
only for TEST_COMPARE, and remove all the other gorp. What we're trying
to do here, is to have the effect of -Wsign-compare. Surely it's better
to do this check at compile-time with the compiler's help, rather than
try to dodge the compiler and do the check at run-time.
I'm not certain about that at all—the *types* could well differ in
signedness between architectures (as it is common for char). This is
the main reason why I only want to test the values.
Florian