This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Arnd Bergmann <arnd at arndb dot de>, John Stultz <john dot stultz at linaro dot org>, Thomas Gleixner <tglx at linutronix dot de>
Cc: y2038 at lists dot linaro dot org, libc-alpha at sourceware dot org, linux-kernel at vger dot kernel dot org, linux-arch at vger dot kernel dot org, linux-api at vger dot kernel dot org, Albert ARIBAUD <albert dot aribaud at 3adev dot fr>, Richard Henderson <rth at twiddle dot net>, Ivan Kokshaysky <ink at jurassic dot park dot msu dot ru>, Matt Turner <mattst88 at gmail dot com>, Al Viro <viro at zeniv dot linux dot org dot uk>, Ingo Molnar <mingo at kernel dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, Deepa Dinamani <deepa dot kernel at gmail dot com>, Greg Kroah-Hartman <gregkh at linuxfoundation dot org>, "Eric W. Biederman" <ebiederm at xmission dot com>, Oleg Nesterov <oleg at redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, Kirill Tkhai <ktkhai at virtuozzo dot com>, linux-alpha at vger dot kernel dot org
Date: Mon, 27 Nov 2017 09:52:06 -0800
Subject: Re: [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times
Authentication-results: sourceware.org; auth=none
References: <20171127170121.634826-1-arnd@arndb.de> <20171127170121.634826-3-arnd@arndb.de>

On 11/27/2017 09:00 AM, Arnd Bergmann wrote:

b) Extend the approach taken by the x32 ABI, and use the 64-bit
    native structure layout for rusage on all architectures with new
    system calls that is otherwise compatible. A possible problem here
    is that we end up with incompatible definitions of rusage between
    /usr/include/linux/resource.h and /usr/include/bits/resource.h

c) Change the definition of struct rusage to be independent of
    time_t. This is the easiest change, as it does not involve new system
    call entry points, but it has the risk of introducing compile-time
    incompatibilities with user space sources that rely on the type
    of ru_utime and ru_stime.

I'm picking approch c) for its simplicity, but I'd like to hear from
others whether they would prefer a different approach.

(c) would break programs like GNU Emacs, which copy ru_utime andru_stime members into struct timeval variables.

All in all, (b) sounds like it would be better for programs using glibc,as it's more compatible with what POSIX apps expect. Though I'm not surewhat problems are meant by "possible ... incompatible definitions";perhaps you could elaborate.

Follow-Ups:
- Re: [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times
  - From: Eric W. Biederman

References:
- [PATCH 1/3] y2038: introduce struct __kernel_old_timeval
  - From: Arnd Bergmann
- [PATCH 3/3] y2038: rusage: use __kernel_old_timeval for process times
  - From: Arnd Bergmann

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]