This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Implement the mlock2 function

From: Florian Weimer <fweimer at redhat dot com>
To: Rical Jasan <ricaljasan at pacific dot net>
Cc: libc-alpha at sourceware dot org
Date: Mon, 27 Nov 2017 11:25:38 +0100
Subject: Re: [PATCH] Implement the mlock2 function
Authentication-results: sourceware.org; auth=none
References: <20171124165936.9CEC94071C775@oldenburg.str.redhat.com> <d6356826-8fe4-2a11-dbc0-a0c81fb86c50@pacific.net>

On 11/28/2017 10:25 AM, Rical Jasan wrote:

+Like @code{mlock}, @code{mlock2} returns zero on success and @code{-1}


I thought you were in the @math camp for return values.  :P


mlock uses @code, so it was a difficult decision.  8-/

  @deftypefun int munlock (const void *@var{addr}, size_t @var{len})
  @standards{POSIX.1b, sys/mman.h}
  @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}


The rest of the patch looked OK to me, but I'm not able to give an
authoritative ACK on it.  Seemed straightforward though.


I'm waiting for more feedback on the ENOSYS masking behavior.

Thanks,
Florian

References:
- [PATCH] Implement the mlock2 function
  - From: Florian Weimer
- Re: [PATCH] Implement the mlock2 function
  - From: Rical Jasan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]