This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] lv_LV locale: fix collation [BZ #15537]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Mike FABIAN <mfabian at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 20 Nov 2017 15:41:20 -0800
- Subject: Re: [PATCH] lv_LV locale: fix collation [BZ #15537]
- Authentication-results: sourceware.org; auth=none
- References: <s9dbmjxthya.fsf@taka.site>
On 11/20/2017 01:31 AM, Mike FABIAN wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=15537
>
> Order without my patch:
>
> $ LC_ALL=lv_LV.UTF-8 ls
> Ʒ a Aa æ Āb c D i Y yb Īb ĵa L ņ ra Ŗa Sa š T Zb ža
> ʒ ʒa aa Ā āb Ç Ģ Ia y Ī īb Ĵb Ļ O Rb ŗa sa Ša Z zb Žb
> ȥ Ʒa Ab ā ʒb ç ģ ia Ya ī Ĵ ĵb ļ Ø rb Ŗb Sb ša z Ž žb
> Ȥ Å ab Āa Ʒb Č H Ib ya Īa ĵ Ķ M ø Ŗ ŗb sb Šb Za ž
> A å Æ āa C č I ib Yb īa Ĵa ķ Ņ Ra ŗ S Š šb za Ža
> $
>
> Order with my patch:
>
> bash-4.4# LC_ALL=lv_LV.UTF-8 ls
> a Ā ab Æ č H y Īa īb Ĵ ķ M Ø ŗ Ŗb Sb šb Z zb Ža ʒa
> A aa Ab c Č i Y ya Īb ĵa Ķ ņ ra Ŗ S š Šb ȥ Zb žb Ʒa
> å Aa āb C D I ia Ya yb Ĵa L Ņ Ra ŗa sa Š t Ȥ ž Žb ʒb
> Å āa Āb ç ģ ī Ia ib Yb ĵb ļ O rb Ŗa Sa ša T za Ž ʒ Ʒb
> ā Āa æ Ç Ģ Ī īa Ib ĵ Ĵb Ļ ø Rb ŗb sb Ša z Za ža Ʒ
> bash-4.4#
>
> So I think this patch fixes the problems reported in the bug
> by using
>
> copy "iso14651_t1"
>
> and then add the same collation tailoring for Latvian as in CLDR
> instead of implementing the whole collation for Latvian from
> scratch as it is currently done in glibc.
Please add a test case which documents the expected ordering.
It is relatively easy to add one of the collation tests with
input data already sorted with comments.
--
Cheers,
Carlos.