This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: tst-ttyname failure
- From: Luke Shumaker <lukeshu at lukeshu dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Christian Brauner <christian dot brauner at ubuntu dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 20 Nov 2017 00:17:03 -0500
- Subject: Re: tst-ttyname failure
- Authentication-results: sourceware.org; auth=none
- References: <a0879626-0112-5445-ca65-c960e0895247@redhat.com>
On Fri, 17 Nov 2017 16:28:44 -0500,
Florian Weimer wrote:
> I need the two attached patches in order to get tst-ttyname to succeed
> when running on Fedora as a non-root user.
>
> info: entering chroot 1
> info: testcase: basic smoketest
> info: ttyname: PASS {name="/dev/pts/5", errno=0}
> info: ttyname_r: PASS {name="/dev/pts/5", ret=0, errno=0}
> error: ../sysdeps/unix/sysv/linux/tst-ttyname.c:122: write (setroups,
> "deny"): Operation not permitted
> info: entering chroot 2
> error: ../sysdeps/unix/sysv/linux/tst-ttyname.c:122: write (setroups,
> "deny"): Operation not permitted
> error: 2 test failures
>
> I get the same failure when running the test on
> kernel-3.10.0-768.el7.x86_64 (there I tested as root).
>
> This is on top of master with commit
> ce003e5d4cd94c5380699b0dadeaaf825813afbe (support_become_root: Enable
> file creation in user namespaces). The test failure was present
> before I pushed that change.
>
> Would you please double-check that they do not break the test on
> whatever distributions you tested on and do not interfere with the
> test objective?
I'm a bit confused why being mounted MS_SHARED caused writing to (but
not opening) /proc/self/setgroups to fail; and not some other issues.
But, I don't believe that this affects the test objectives, and I have
verified that it doesn't break the test here on Parabola.
(Sorry I didn't reply on Friday, I'm traveling.)
--
Happy hacking,
~ Luke Shumaker