This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] support_become_root: Don't fail when /proc/<pid/setgroups is missing
- From: Christian Brauner <christian dot brauner at canonical dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Christian Brauner <christian dot brauner at ubuntu dot com>, libc-alpha at sourceware dot org
- Date: Sat, 18 Nov 2017 16:19:23 +0100
- Subject: Re: [PATCH v2] support_become_root: Don't fail when /proc/<pid/setgroups is missing
- Authentication-results: sourceware.org; auth=none
- References: <20171118151311.20305-1-christian.brauner@ubuntu.com> <5966e5a2-240f-66db-88b3-71ecaad1028f@redhat.com>
On Sat, Nov 18, 2017 at 04:15:41PM +0100, Florian Weimer wrote:
> On 11/18/2017 04:13 PM, Christian Brauner wrote:
> > The requirement to write "deny" to/proc/<pid>/setgroups for a given user
> > namespace before being able to write a gid mapping was introduced in Linux
> > 3.19. Before that this requirement including the file did not exist.
> > So don't fail when errno == ENOENT.
> >
> > Signed-off-by: Christian Brauner<christian.brauner@ubuntu.com>
>
> glibc uses an FSF copyright assignment and not the DCO, so this line is
> misleading.
Right, I'm removing it. It gets auto-added due to my .gitconfig. :)
Thanks!
Christian