This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]
- From: DJ Delorie <dj at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Cc: fweimer at redhat dot com, libc-alpha at sourceware dot org
- Date: Tue, 14 Nov 2017 20:47:01 -0500
- Subject: Re: [PATCH] malloc: Add missing arena lock in mallinfo [BZ #22408]
- Authentication-results: sourceware.org; auth=none
Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
> statistics reporting in malloc_info" since it does more than adding the
> missing arena lock. That or split out the loop to iterate over heaps
> into a separate patch since it is a logically distinct change from the
> fix to BZ#22408, with a bz to track the fix. I prefer the latter approach.
I don't see the benefit of splitting up the patch, as there would be no
patch left - Florian's solution did not require any changes to the
locks. Given no obvious change specific to the BZ, I think it's OK to
use the existing patch to close the existing BZ as "fixed by other
means".
So +1 for the patch as-is, from me.