This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH v9 0/6][BZ 10871] Month names in alternative grammatical case
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 6 Nov 2017 22:18:19 +0100 (CET)
- Subject: Re: [RFC][PATCH v9 0/6][BZ 10871] Month names in alternative grammatical case
- Authentication-results: sourceware.org; auth=none
- References: <222125290.1094501.1505817563211@poczta.nazwa.pl> <1019797598.130228.1506422749965@poczta.nazwa.pl> <1248484263.359848.1506987781241@poczta.nazwa.pl> <295818138.661471.1507631459700@poczta.nazwa.pl> <CAKCAbMjgtCdhj+9Z_kvKvtw_awuBUvFhmiXVB_sG+syK0SQdjg@mail.gmail.com> <1633830687.25023.1508928625470@poczta.nazwa.pl> <CAKCAbMhZX5PeyZF5xv=KxJQP2GMr3wAuV=PiCcUHLBWKQnPiyA@mail.gmail.com>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
Zack,
Thank you for your review and I'm sorry for my delayed response.
I'm currently applying your suggestions. Please see my answers
inline:
27.10.2017 17:14 Zack Weinberg <zackw@panix.com> wrote:
> [...]
> I sense that you are confused by both the request to not send
> generated-but-checked-in files for review, and the desired procedure
> for handling them in the commits that actually get pushed,
Yes, first of all I thought that once the patch is reviewed and accepted
for commit it should be committed without changing a single bit
because any change may potentially introduce bugs. Now I understand
that some reasonable changes are possible and even desired.
> so let me
> explain why we do it this way: [...]
> [ cut detailed explanation ]
Thank you for this detailed explanation. I believe it's very valuable.
That's off-topic, but don't you mind if I copy it (with minor edits)
to the Contribution Checklist wiki article [1] so it will be easier
to find for the potential new contributors (and old ones, too)?
Regards,
Rafal