This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/6] Cleanup Linux sigqueue implementation



On 06/11/2017 12:05, Zack Weinberg wrote:
> On Mon, Nov 6, 2017 at 5:59 AM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> On 05/11/2017 19:30, Zack Weinberg wrote:
>>> On Fri, Nov 3, 2017 at 5:40 PM, Adhemerval Zanella
>>> <adhemerval.zanella@linaro.org> wrote:
>>>> This patch simplify Linux sigqueue implementation by assuming
>>>> __NR_rt_sigqueueinfo existence due minimum kernel requirement.
>>>>
>>>> Checked on x86_64-linux-gnu.
>>>>
>>>>         * sysdeps/unix/sysv/linux/sigqueue.c (__sigqueue): Asssume
>>>>         __NR_rt_sigqueueinfo.
>>>
>>> OK, but please state in the commit message the oldest kernel version
>>> that provided __NR_rt_sigqueueinfo on all architectures.
>>
>> I am trying to find out exactly when realtime signals were introduced
>> on Linux and it seems it pre-dates git and so Linux 2.6.12 (commit
>> 1da177e4 added both the headers and the systbl linkage on alpha
>> for instance).  I think stating it is present on Linux 2.6 should
>> be suffice.
> 
> Yeah, that's fine.  I just want there to be no confusion in the future.
> 
> I think you should go ahead and push the components of this patchset
> that are fully reviewed and don't depend on other work, like this one
> and the one cleaning up sigtimedwait and friends.
> 
> zw
> 

Right, I will push both the sigqueue and the sigtimedwait simplify.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]