This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Separate patch reviews for support/ additions?
- From: Carlos O'Donell <carlos at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>, Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 3 Nov 2017 14:57:17 -0700
- Subject: Re: Separate patch reviews for support/ additions?
- Authentication-results: sourceware.org; auth=none
- References: <xnmv43111e.fsf@greed.delorie.com>
On 11/03/2017 02:54 PM, DJ Delorie wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>> Do we want separate patch reviews for any new support/ functions? Or
>> should we just add them along with test cases that need them?
>
> If the question is, "should we review new things in support/?" I think
> the answer is obviously yes.
>
> But I assume the question is, "should they be reviewed separately, or
> bundled?" I prefer bundled - we have a large enough patch backlog
> already without artificially increasing traffic. Also, seeing the
> context might help with the review. It would certainly short-circuit
> the "why do we need this?" questions ;-)
Agreed. I said this in my other email, but the context helps the review.
--
Cheers,
Carlos.