This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Filter out NPTL internal signals (BZ #22391)


On Fri, 3 Nov 2017, Adhemerval Zanella wrote:

> 	* signal/sigaddset.c (sigaddset): Likewise.
> 	* signal/sigdelset.c (sigdelset): Likewise.
> 	* sysdeps/posix/signal.c (__bsd_signal): Likewise.
> 	* sysdeps/posix/sigset.c (sigset): Call and check sigaddset return
> 	value.
> 	* signal/sigfillset.c (sigfillset): User __nptl_clear_internal_signals
> 	to filter out internal nptl signals.
> 	* signal/tst-sigset.c (do_test): Check ech signal indidually and
> 	also check realtime signals using standard macros.

I don't think non-NPTL, non-Linux files like this should be referring to 
NPTL-internal interfaces.  You could have some interface for indicating 
"is internal signal" that doesn't refer to NPTL and would equally apply to 
other threading implementations.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]