This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Separate patch reviews for support/ additions?
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 3 Nov 2017 14:53:38 -0700
- Subject: Re: Separate patch reviews for support/ additions?
- Authentication-results: sourceware.org; auth=none
- References: <1da9a7f4-5090-7e93-912b-be62db21fed7@redhat.com>
On 11/03/2017 02:04 PM, Florian Weimer wrote:
> Do we want separate patch reviews for any new support/ functions? Or
> should we just add them along with test cases that need them?
Is there any benefit to having a distinct patch/commit for the support
functions?
I would think that having just one review for the test and the functions
it needs would be sufficient.
It lets the reviewer analyze how the functions are going to be used in
a real example.
--
Cheers,
Carlos.