This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Separate patch reviews for support/ additions?


On 11/03/2017 02:04 PM, Florian Weimer wrote:
> Do we want separate patch reviews for any new support/ functions?  Or
> should we just add them along with test cases that need them?

Is there any benefit to having a distinct patch/commit for the support
functions?

I would think that having just one review for the test and the functions
it needs would be sufficient.

It lets the reviewer analyze how the functions are going to be used in
a real example.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]