This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Reformat sysdeps/x86/libc-start.c

From: Florian Weimer <fweimer at redhat dot com>
To: Jonathan Nieder <jrnieder at gmail dot com>, Carlos O'Donell <carlos at redhat dot com>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 2 Nov 2017 19:40:31 +0100
Subject: Re: [PATCH] Reformat sysdeps/x86/libc-start.c
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 742C837E8E
References: <20171030200246.GA14084@intel.com> <4bcfa16d-bce2-55ed-77f2-69502b2ecfff@redhat.com> <CAMe9rOrrDCqMgT+AaLCtWgTADBc6d5ZvkCo9+5HWgGCP-qT6MQ@mail.gmail.com> <6c3b36c8-fb8d-69e4-2dd3-6ba41c1eef9f@redhat.com> <20171030221214.uup2uy7p3a7neyqv@aiede.mtv.corp.google.com>

On 10/30/2017 11:12 PM, Jonathan Nieder wrote:

Hi,

Carlos O'Donell wrote:

Should we extend consensus?

https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
~~~
Anyone can commit a change fixing obvious coding standards problems
in a recently committed patch. Post the patch and ChangeLog to
libc-alpha with a short message and then push the commit.
~~~
s/a recently/any/g

We normally allow this kind of change for "recently committed"
patches, but shy away from it for older changes because of the impact
it might ave on established code.

In this case I would have liked HJ to be able to just push the cleanup
without anyone *needing* to do a pre-commit review.


I would rather not --- getting LGTM is a pretty lightweight action,

I must say that I agree with Carlos here. Even what should be a trivialreview is often difficult to get, and a lot of cleanups land onlybecause the author eventually commits their changes without review.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] Reformat sysdeps/x86/libc-start.c
  - From: Jonathan Nieder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]