This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/7] [PowerPC64] Wrap str{,n}cmp-power{8,9}.S in IS_IN(libc)

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: libc-alpha at sourceware dot org
Date: Mon, 30 Oct 2017 09:47:00 -0200
Subject: Re: [PATCH 3/7] [PowerPC64] Wrap str{,n}cmp-power{8,9}.S in IS_IN(libc)
Authentication-results: sourceware.org; auth=none
References: <cover.1508908223.git.amodra@gmail.com> <4bbab4043c66fd834d3021fb394d1feb524d6130.1508908224.git.amodra@gmail.com>


On 25/10/2017 05:36, Alan Modra wrote:
> These functions aren't used in ld.so at the moment since we don't have
> strcmp or strncmp ifuncs for them there.  Remove the ld.so bloat.
> 
> 	* sysdeps/powerpc/powerpc64/multiarch/strcmp-power8.S: Wrap in
> 	IS_IN (libc).
> 	* sysdeps/powerpc/powerpc64/multiarch/strcmp-power9.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/multiarch/strncmp-power8.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/multiarch/strncmp-power9.S: Likewise.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

> 
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcmp-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strcmp-power8.S
> index b2464a8..b0d2d37 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strcmp-power8.S
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strcmp-power8.S
> @@ -18,9 +18,11 @@
>  
>  #include <sysdep.h>
>  
> +#if IS_IN (libc)
>  #define STRCMP __strcmp_power8
>  
>  #undef libc_hidden_builtin_def
>  #define libc_hidden_builtin_def(name)
>  
>  #include <sysdeps/powerpc/powerpc64/power8/strcmp.S>
> +#endif
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcmp-power9.S b/sysdeps/powerpc/powerpc64/multiarch/strcmp-power9.S
> index 48ea05d..7a8488a 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strcmp-power9.S
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strcmp-power9.S
> @@ -18,9 +18,11 @@
>  
>  #include <sysdep.h>
>  
> +#if IS_IN (libc)
>  #define STRCMP __strcmp_power9
>  
>  #undef libc_hidden_builtin_def
>  #define libc_hidden_builtin_def(name)
>  
>  #include <sysdeps/powerpc/powerpc64/power9/strcmp.S>
> +#endif
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strncmp-power8.S
> index 3cbcaad..49b7adf 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp-power8.S
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp-power8.S
> @@ -17,9 +17,11 @@
>  
>  #include <sysdep.h>
>  
> +#if IS_IN (libc)
>  #define STRNCMP __strncmp_power8
>  
>  #undef libc_hidden_builtin_def
>  #define libc_hidden_builtin_def(name)
>  
>  #include <sysdeps/powerpc/powerpc64/power8/strncmp.S>
> +#endif
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp-power9.S b/sysdeps/powerpc/powerpc64/multiarch/strncmp-power9.S
> index 6d0deaa..e1a961c 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp-power9.S
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp-power9.S
> @@ -17,9 +17,11 @@
>  
>  #include <sysdep.h>
>  
> +#if IS_IN (libc)
>  #define STRNCMP __strncmp_power9
>  
>  #undef libc_hidden_builtin_def
>  #define libc_hidden_builtin_def(name)
>  
>  #include <sysdeps/powerpc/powerpc64/power9/strncmp.S>
> +#endif
>

References:
- [PATCH 0/7] PowerPC64le multi-arch
  - From: Alan Modra
- [PATCH 3/7] [PowerPC64] Wrap str{,n}cmp-power{8,9}.S in IS_IN(libc)
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]